Added broadcast overload for bool

xtensor-stack · Feb 24, 2025 · 9deba5b · 9deba5b
1 parent b3c882c
commit 9deba5b
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 3 deletions.
diff --git a/include/xsimd/arch/generic/xsimd_generic_memory.hpp b/include/xsimd/arch/generic/xsimd_generic_memory.hpp
@@ -32,6 +32,34 @@ namespace xsimd
 
         using namespace types;
 
+        // broadcast
+        namespace detail
+        {
+            template <class T, class A>
+            struct broadcaster
+            {
+                using value_type = T;
+                using return_type = batch<T, A>;
+
+                static return_type run(T v) noexcept
+                {
+                    return return_type::broadcast(v);
+                }
+            };
+
+            template <class A>
+            struct broadcaster<bool, A>
+            {
+                using value_type = uint8_t;
+                using return_type = batch_bool<uint8_t, A>;
+
+                static return_type run(bool b) noexcept
+                {
+                    return return_type(b);
+                }
+            };
+        }
+
         // compress
         namespace detail
         {

diff --git a/include/xsimd/types/xsimd_api.hpp b/include/xsimd/types/xsimd_api.hpp
@@ -491,10 +491,11 @@ namespace xsimd
      * @return a new batch instance
      */
     template <class T, class A = default_arch>
-    XSIMD_INLINE batch<T, A> broadcast(T v) noexcept
+    XSIMD_INLINE typename kernel::detail::broadcaster<T, A>::return_type broadcast(T v) noexcept
     {
-        detail::static_check_supported_config<T, A>();
-        return batch<T, A>::broadcast(v);
+        using value_type = typename kernel::detail::broadcaster<T, A>::value_type;
+        detail::static_check_supported_config<value_type, A>();
+        return kernel::detail::broadcaster<T, A>::run(v);
     }
 
     /**

diff --git a/test/test_api.cpp b/test/test_api.cpp
@@ -23,6 +23,7 @@ struct xsimd_api_test
 {
     using batch_type = B;
     using batch_bool_type = typename B::batch_bool_type;
+    using arch_type = typename B::arch_type;
     using value_type = typename B::value_type;
     static constexpr size_t size = B::size;
     using array_type = std::array<value_type, size>;
@@ -100,6 +101,7 @@ struct xsimd_api_test
 
     void test_set()
     {
+        test_set_bool("set bool");
         test_set_impl<int8_t>("set int8_t");
         test_set_impl<uint8_t>("set uint8_t");
         test_set_impl<int16_t>("set int16_t");
@@ -171,6 +173,15 @@ struct xsimd_api_test
         CHECK_BATCH_EQ(res, expected);
     }
 
+    void test_set_bool(const std::string& name)
+    {
+        bool v = true;
+        xsimd::batch_bool<uint8_t, arch_type> expected(v);
+        xsimd::batch_bool<uint8_t, arch_type> res = xsimd::broadcast(v);
+        INFO(name);
+        CHECK_BATCH_EQ(res, expected);
+    }
+
     template <class V>
     void init_test_vector(V& vec)
     {