-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Timer Handling and Prevent Memory Leaks #297
Conversation
Seems like the issue could be solved in Go 1.23 |
Interesting, Thanks for sharing. Right now this library uses 1.18, I am not sure upgrading the golang version is a better idea or changing time.After() to time.NewTicker() |
Hi, thank you for pr, but in dev v.1.11 i rewrote much logic related to rldp and adnl, so it is a bit irrelevant now :( some parts was removed and some conflicts. Could you please merge it with dev-v1-11? By the way, if you build using go 1.23 you are getting features from compiler version, go.mod just indicates minimal supported version, so im holding it low |
Hi! sure. as you changed the base branch from master to dev-v1-11, I have two options, rebase the dev-v1-11 to my master and add push, or you have to change my base branch from master to dev-v1-11, so you merge my dev-v1-11 with your dev-v1-11. |
… accuracy to avoid memory leaks
…roved timer handling to avoid memory leaks
…acy and to avoid memory leaks
Rebased. what's the next step? |
Thank you, merged |
Your welcome! Is there any estimated time for releasing this new version? |
Will try today |
@m0leynik The strange part is I am using |
@iw4p
https://go.dev/ref/mod#go-mod-file-go @xssnick |
No, I mean the docker image of golang. I didn't change the go.mod version. @m0leynik |
Hi! I realized some allocs and goroutine leaks in this library as I am working with it on the production. Using pprof and graphviz I realized the problem is time.After() because it shows time NewTimer
examples: 1 - 2