Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement TransferWaitTransaction to get tx and block #228

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

iw4p
Copy link
Contributor

@iw4p iw4p commented Aug 1, 2024

Implement B̶r̶o̶a̶d̶c̶a̶s̶t̶T̶r̶a̶n̶s̶a̶c̶t̶i̶o̶n̶s̶A̶n̶d̶W̶a̶i̶t̶ TransferWaitTransaction to get tx and block from single transaction based on this issue

@iw4p iw4p mentioned this pull request Aug 1, 2024
Copy link
Owner

@xssnick xssnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR! Lets address some changes, so it will be a bit more flexible and clear

ton/wallet/wallet.go Outdated Show resolved Hide resolved
ton/wallet/wallet.go Outdated Show resolved Hide resolved
ton/wallet/wallet.go Outdated Show resolved Hide resolved
@iw4p
Copy link
Contributor Author

iw4p commented Aug 1, 2024

Hi, you're welcome!
nice points, I fixed them.

@iw4p iw4p changed the title feat: implement BroadcastTransactionsAndWait to get tx and block feat: implement TransferWaitTransaction to get tx and block Aug 7, 2024
@iw4p
Copy link
Contributor Author

iw4p commented Aug 11, 2024

Hi, shall I do something for rebase/merge? Or just wait? When do you plan to publish the new version?

@xssnick
Copy link
Owner

xssnick commented Aug 12, 2024

Hi, i will merge when next version will be ready

@iw4p
Copy link
Contributor Author

iw4p commented Aug 12, 2024

Cool!

@xssnick xssnick changed the base branch from master to dev-v19 September 10, 2024 08:57
@xssnick xssnick merged commit 1ac11ea into xssnick:dev-v19 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants