Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Change to use lestrrat jwx in anticipation of additional JWS/JWE… #257

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

schmidtw
Copy link
Member

… support needs.

Copy link

guardrails bot commented Dec 22, 2024

⚠️ We detected 2 security issues in this pull request:

Vulnerable Libraries (2)
Severity Details
High pkg:golang/github.com/lestrrat-go/jwx/v2@v2.1.3 upgrade to: > v2.1.3
High pkg:golang/github.com/xmidt-org/sallust@v0.2.3 upgrade to: > v0.2.3

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 76.99115% with 26 lines in your changes missing coverage. Please review.

Project coverage is 77.05%. Comparing base (4d1f3bb) to head (fe75f20).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/credentials/cmd/example/main.go 0.00% 18 Missing ⚠️
internal/jwtxt/options.go 90.00% 5 Missing and 2 partials ⚠️
internal/jwtxt/token.go 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   74.36%   77.05%   +2.68%     
==========================================
  Files          74       74              
  Lines        5669     5722      +53     
==========================================
+ Hits         4216     4409     +193     
+ Misses       1248     1115     -133     
+ Partials      205      198       -7     
Flag Coverage Δ
unittests 77.05% <76.99%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmidtw schmidtw merged commit 150c958 into main Dec 22, 2024
16 of 18 checks passed
@schmidtw schmidtw deleted the switch-to-lestrrat-jwx branch December 22, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant