Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Upgrade native SDKs #106

Merged
merged 13 commits into from
May 23, 2023
Merged

[Feature] Upgrade native SDKs #106

merged 13 commits into from
May 23, 2023

Conversation

emibotti
Copy link
Contributor

Upgrade native SDKs

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

Upgrades to new version of the line SDK and adds several fixes.
Tested with React Native 0.72.3 and works both in iOS and Android.


@emibotti emibotti requested review from mirland and nicoache1 May 23, 2023 16:34
README.md Outdated
@@ -59,10 +59,8 @@ First, install the npm package with yarn. _Autolink_ is automatic.
Inside your `AppDelegate.m`, setup the line sdk by passing the channel id obtained.

1. Add `platform :ios, '10.0'` in `Podfile` line:1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be 11 or 12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@emibotti emibotti merged commit bc75133 into master May 23, 2023
@emibotti emibotti deleted the feature/upgrade-native-sdks branch May 23, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants