Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh_Hans.po (Chinese Simplified) to po directory #21

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

larryw3i
Copy link
Contributor

@larryw3i larryw3i commented Aug 9, 2021

Add zh_Hans.po to po directory, by the way, running "cargo build --release" doesn't work for me, the version of dependencies.gio is not specified.
Screenshot from 2021-08-10 07-34-27

@xlmnxp
Copy link
Owner

xlmnxp commented Aug 10, 2021

you can run it by

cargo run

@larryw3i
Copy link
Contributor Author

you can run it by

cargo run

Buddy, It still crashs.

$ cargo run
error: failed to parse manifest at `/home/larry/fun/larryw3i/blue-recorder/Cargo.toml`

Caused by:
  failed to parse the version requirement `` for dependency `gio`

Caused by:
  unexpected end of input while parsing major version number

How do I solve it?

@larryw3i
Copy link
Contributor Author

you can run it by

cargo run

https://github.com/xlmnxp/blue-recorder/blob/master/Cargo.toml#L26#L28
Don't we need a version of gio?

@larryw3i
Copy link
Contributor Author

@xlmnxp Thank you, It works for me now.

Screenshot from 2021-08-10 18-03-51

@xlmnxp
Copy link
Owner

xlmnxp commented Aug 10, 2021

@xlmnxp Thank you, It works for me now.

Screenshot from 2021-08-10 18-03-51

thank you
Can you commit the changes in Cargo.toml?

@larryw3i larryw3i closed this Aug 10, 2021
@larryw3i larryw3i reopened this Aug 10, 2021
@larryw3i
Copy link
Contributor Author

@xlmnxp Thank you, It works for me now.
Screenshot from 2021-08-10 18-03-51

thank you
Can you commit the changes in Cargo.toml?

I have committed it.
https://github.com/xlmnxp/blue-recorder/pull/21/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542R27

@larryw3i
Copy link
Contributor Author

zh_CN is much the same as zh_Hans, so I submitted zh_CN.po as well.

@larryw3i
Copy link
Contributor Author

larryw3i commented Aug 10, 2021

But It seems that multilingual feature still doesn't work for me. I don't know how to test it.
Screenshot from 2021-08-10 21-02-37

@xlmnxp
Copy link
Owner

xlmnxp commented Aug 10, 2021

But It seems that multilingual feature still doesn't work for me. I don't know how to test it.
Screenshot from 2021-08-10 21-02-37

I will fix it soon, thank you from your contribution
it will make blue recorder better

@xlmnxp xlmnxp merged commit 365b92d into xlmnxp:master Aug 10, 2021
ochibani pushed a commit to ochibani/blue-recorder that referenced this pull request Jan 9, 2025
Add zh_Hans.po (Chinese Simplified) and zh_CN.po to  po directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants