Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter compile error when wrong quote #49

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix filter compile error when wrong quote #49

merged 1 commit into from
Jan 24, 2024

Conversation

xinz
Copy link
Owner

@xinz xinz commented Jan 24, 2024

Error involved in #38

** (CompileError) nofile:1: you must require ExAliyunOts.Const.FilterType before invoking the
macro ExAliyunOts.Const.FilterType.composite_column/0

or

 ** (CompileError) nofile:1: you must require ExAliyunOts.Const.FilterType before invoking the
macro ExAliyunOts.Const.FilterType.single_column/0

Now the corresponding test case added to cover it.

@xinz xinz requested a review from feng19 January 24, 2024 09:57
@xinz xinz merged commit 7102cb8 into master Jan 24, 2024
@xinz xinz deleted the fix-filter branch January 24, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feng19 feng19 feng19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinz @feng19