revert: tiff2imag method ,part of commit 5d9b930de5472e933d5260837569… #2205
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/tiff.cc
Outdated
Comment on lines
26
to
27
| memcpy( data.data(), ba.data(), ba.size() ); | ||
| data.resize( ba.size() ); |
There was a problem hiding this comment.
Don't revert anything else except swap the order of those 2 lines.
QBuffer control the content of the QByteArray ba. The original code involves an implicit conversion QByteaArray->char*.
Also, &std::vector::front is a crash if the vector is empty. It generally shouldn't occur in post-c++11 code.
|
Thanks. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2202