Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ptr and associated free #131

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

jeanlucf22
Copy link
Contributor

I found a few pointers that were never used, expect in calls to free them. Not sure if it leads to memory errors, but triggers some warnings from valgrind

@xiaoyeli
Copy link
Owner

xiaoyeli commented Jan 4, 2023

@jeanlucf22 Thanks for providing these fixes.
I reviewed them, your fixes look correct. However, these are all on GPU side, perhaps it won't solve your problem with corrected "B" and "X", which is on CPU.

@piyush314 : can you please review these fixes? If they look correct to you, I can merge the pull request.

Thanks.
Sherry

@xiaoyeli xiaoyeli merged commit 59e37bc into xiaoyeli:master Jan 10, 2023
@xiaoyeli
Copy link
Owner

@jeanlucf22
We review this, and I merged the PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants