Dev for 1.25.3 #276
Merged
Dev for 1.25.3 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
... and drop legacy ClusterID support. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
If CCM and ServiceLB are both disabled, don't run the cloud-controller-manager at all; this should provide the same CLI flag behavior as previous releases, and not create problems when users disable the CCM but still want ServiceLB. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
We should be reading from the hijacked bufio.ReaderWriter instead of directly from the net.Conn. There is a race condition where the underlying http handler may consume bytes from the hijacked request stream, if it comes in the same packet as the CONNECT header. These bytes are left in the buffered reader, which we were not using. This was causing us to occasionally drop a few bytes from the start of the tunneled connection's client data stream. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
The kubelet port can be overridden by users; we shouldn't assume its always 10250 Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: jongwooo <han980817@gmail.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
* Replace ioutil package Signed-off-by: Derek Nola <derek.nola@suse.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
For 1.24 and earlier, the svclb pods need a ServiceAccount so that we can allow their sysctls in PSPs Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: matttrach matttrach@gmail.com porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
The InstancesV1 interface handled this for us by combining the ProviderName and InstanceID values; the new interface requires us to do it manually Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com> porting by Signed-off-by: Deshi Xiao <xiaods@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.