for loop for azimuthal averaging in isotropic functions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may be able to improve this in the future using my new xhistogram package. For now it's fine as is. |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 95.66% 96.48% +0.82%
==========================================
Files 2 2
Lines 692 712 +20
Branches 119 123 +4
==========================================
+ Hits 662 687 +25
+ Misses 16 14 -2
+ Partials 14 11 -3
Continue to review full report at Codecov.
|
rabernat
requested changes
Apr 10, 2019
xrft/xrft.py
Outdated
| for i in range(M[1]): | ||
| iso_ps[j,i] = _azimuthal_avg(kidx, f[j,i], area, kr) | ||
| else: | ||
| raise ValueError("Arrays with more than 4 dimensions is not supported.") |
xrft/xrft.py
Outdated
| for i in range(M[1]): | ||
| iso_cs[j,i] = _azimuthal_avg(kidx, f[j,i], area, kr) | ||
| else: | ||
| raise ValueError("Arrays with more than 4 dimensions is not supported.") |
There was a problem hiding this comment.
Since you have this code repeated in two functions, you should probably break it into a private standalone function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I inserted a for loop for the
isotropicfunctions so that it can take arrays up to 4 dimensions.