Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize isotropize #128

Merged
merged 7 commits into from
Dec 8, 2020
Merged

Parallelize isotropize #128

merged 7 commits into from
Dec 8, 2020

Conversation

roxyboy
Copy link
Member

@roxyboy roxyboy commented Nov 25, 2020

I implemented @shoyer 's amazing numpy_groupies hack to parallelize the isotropization of spectra. This addresses issues #9 and #87 .

@rabernat
Copy link
Collaborator

rabernat commented Nov 25, 2020

This is cool Takaya! We could also potentially use this in xhistogram

I will review this after the Thanksgiving holiday.

@rabernat
Copy link
Collaborator

p.s. Isn't this going into xarray itself? Is it necessary to put it in xrft?

@roxyboy
Copy link
Member Author

roxyboy commented Nov 25, 2020

p.s. Isn't this going into xarray itself? Is it necessary to put it in xrft?

I think it eventually is going to but I checked the xarray issue log and it seems that there's still some issues for it to be implemented upstream. So I figured I'd just add it to xrft in the mean time.

@roxyboy
Copy link
Member Author

roxyboy commented Dec 4, 2020

@rabernat Do you think we should keep this PR out until numpy_groupies gets implemented more upstream?

Copy link
Collaborator

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Do we have tests for this feature already? If so, I approve.

@roxyboy
Copy link
Member Author

roxyboy commented Dec 8, 2020

This looks great! Do we have tests for this feature already? If so, I approve.

The test_isotropize tests isotropization for both chunked and non-chunked data so I think the pre-existing tests cover this feature. But I'll add a bit more to the test that checks the slopes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants