-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize isotropize #128
Conversation
This is cool Takaya! We could also potentially use this in xhistogram I will review this after the Thanksgiving holiday. |
p.s. Isn't this going into xarray itself? Is it necessary to put it in xrft? |
I think it eventually is going to but I checked the |
@rabernat Do you think we should keep this PR out until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Do we have tests for this feature already? If so, I approve.
The |
I implemented @shoyer 's amazing
numpy_groupies
hack to parallelize the isotropization of spectra. This addresses issues #9 and #87 .