clang-format #3
clang-format #3
Conversation
| " COUNT(case library.mixxx_deleted when 0 then 1 else null end) " | ||
| "AS count, " | ||
| " SUM(case library.mixxx_deleted when 0 then library.duration " | ||
| "else 0 end) AS durationSeconds " | ||
| "FROM Playlists " | ||
| "LEFT JOIN PlaylistTracks ON PlaylistTracks.playlist_id = Playlists.id " | ||
| "LEFT JOIN PlaylistTracks ON PlaylistTracks.playlist_id = " | ||
| "Playlists.id " |
There was a problem hiding this comment.
These linebreaks illustrate why I am against automatically hard-wrapping
| auto newName = QInputDialog::getText(nullptr, | ||
| tr("Rename Crate"), | ||
| tr("Enter new name for crate:"), | ||
| QLineEdit::Normal, | ||
| oldName, | ||
| &ok) | ||
| .trimmed(); |
There was a problem hiding this comment.
Yes, right. If you like you can check if you can trick clang-format here.
There was a problem hiding this comment.
have adjusted this, but I think the formatter should never produce something like this.
| CrateId crateId = CrateFeatureHelper(m_pTrackCollection, | ||
| m_pConfig) |
There was a problem hiding this comment.
have adjusted this, but I think the formatter should never produce something like this.
| &LibraryFeature::loadTrack, | ||
| this, | ||
| &Library::slotLoadTrack); | ||
| connect(feature, &LibraryFeature::loadTrack, this, &Library::slotLoadTrack); |
There was a problem hiding this comment.
this is an unexpected inconsistency with the code above and below
There was a problem hiding this comment.
The good thing with our two phase clang-format pre-commit hook is that you can help here.
Clang format will not unbreakable the lines if you break after each parameter.
So if this is itching you, please break this statement manually.
| QStringLiteral("SELECT *, " | ||
| "(SELECT COUNT(*) FROM %1 WHERE %2.%3 = %1.%4 and %1.%5 in (%9)) AS %6, " | ||
| "(SELECT COUNT(*) FROM %1 WHERE %2.%3 = %1.%4 and " | ||
| "%1.%5 in (%9)) AS %6, " | ||
| "0 as %7 FROM %2 ORDER BY %8") | ||
| .arg( | ||
| CRATE_TRACKS_TABLE, | ||
| .arg(CRATE_TRACKS_TABLE, |
There was a problem hiding this comment.
I manually formatted this part and tried to find a balance between length and readability, now the formatter breaks it at some arbitrary point to fit the length
There was a problem hiding this comment.
The original line was 101. I have no idea why clang-format aligns with (. We don't want that.
You may try to manually break after ( and restore the original version.
| CapabilitiesFlags caps = TRACKMODELCAPS_RECEIVEDROPS | | ||
| TRACKMODELCAPS_ADDTOPLAYLIST | TRACKMODELCAPS_ADDTOCRATE | | ||
| TRACKMODELCAPS_ADDTOAUTODJ | TRACKMODELCAPS_EDITMETADATA | | ||
| TRACKMODELCAPS_LOADTODECK | TRACKMODELCAPS_LOADTOSAMPLER | | ||
| TRACKMODELCAPS_LOADTOPREVIEWDECK | TRACKMODELCAPS_REMOVE_CRATE | |
There was a problem hiding this comment.
this was much more readable when each flag had its own line
|
First of all, this PR is just a service for you to get around the pending issues with the pre-commit hook. It is what the pre-commit hook should have been done automatically. I have no Idea why, that has failed for you. Do you. This PR just reflects the agreed .clang-format, so there is no point for discussion, to get the target PR merge. This does not mean that the configuration cannot be improved. I will now respond to your inline comments. |
|
I have accidentally hit the "Close and comment" button. |
|
I have adjusted a few things, but I would like to have the format options revisited to resolve my remaining comments automatically |
No description provided.