Formatter handling improvements and extending python compatibility #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing or invalid in the stream's append_value() function.
…ctor (useful change when loading logging configuration from files using `logging.config.fileConfig()`)
General functions improvements.
Fixed test cases to ensure proper exception handling and correct formatter behavior.
xente
approved these changes
Nov 18, 2024
| timeout=10, | ||
| compressed=True, | ||
| defaultFormatter=LoggerFormatter(), | ||
| additional_headers=dict() | ||
| loguru=False, |
There was a problem hiding this comment.
Now we only have 2 formatters but i want to be able to add more. In this way we are not flexible to use more in the future.
It is ok in this way for the moment but in the future it will be needed to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @xente!
I want to thank you for your work doing this great tool!
I would appreciate a lot if you consider these proposed changes to be merged.
The main changes here are:
All the changes from Pull Request Formatter handling improvements #12 are added here.
-Reorganized the sequence of arguments in the LokiLoggerHandler constructor (useful change when loading logging configuration from files using
logging.config.fileConfig())labelKeysanddefaultFormatterin the LokiLoggerHandler constructor were renamed aslabel_keysanddefault_formatterfor consistency with the naming conventions.For this PR all the scripts were reviewed, adjusted and tested to be compatible with Python 2.7 and keep the compatibility with Python 3.x.
the purpose of this is to make it possible to use the library in Jython applications, which unfortunately currently only supports Python 2.7
All tests are green.