Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added main.py #5

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Added main.py #5

merged 4 commits into from
Oct 13, 2023

Conversation

BBergle
Copy link
Collaborator

@BBergle BBergle commented Oct 9, 2023

Added the skeleton of main.py

I will be working on the logic this week

main.py Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my PR #4 about the poetry build system is accepted, we need to move this file to a "genisys" subdirectory. Otherwise lets at least put in an "src" directory to keep the source, tests, and build files seperate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

main.py Outdated
# TODO: Implement the validation logic here


def install_config(file, change_root=None):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this to change_root='/' you can avoid the if ... else later. Ditto for line 16.

@BBergle BBergle requested a review from a user October 12, 2023 14:42
@BBergle BBergle merged commit 73a1b95 into main Oct 13, 2023
@BBergle BBergle deleted the CLI-app branch October 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants