-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make script available for client download #42
Merged
HenrithicusGreenson
merged 11 commits into
main
from
make-script-available-for-client-download
Jan 26, 2024
Merged
Make script available for client download #42
HenrithicusGreenson
merged 11 commits into
main
from
make-script-available-for-client-download
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All scripts that will be provided for the client will need to be located in the new "scripts" directory. The "use-all" option determines if every single script in the scripts directory will be copied to FTP at run time. If "use-all" is false, only the scripts specified in the "scripts-list" list in the YAML file will be copied to the FTP directory.
Added config option for scripts directory
* All thats left to do is test this method * Put logic in the install method
xeluior
reviewed
Jan 23, 2024
xeluior
approved these changes
Jan 23, 2024
BBergle
approved these changes
Jan 24, 2024
* Removed redundant checking of chroot when creating path objects. * Used simpler syntax for creating directories. NOTE: May need new error checking for if the parent directories don't exist?
xeluior
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From here on, any new modules need to make sure the main.py gets updated to import and run your module
xeluior
approved these changes
Jan 25, 2024
r-akers
approved these changes
Jan 25, 2024
patedm01
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all scripts from a scripts directory specified by the user to a directory accessible hosted on the genisys server which is accessible to client machines via FTP.
Alternatively only moves scripts specified in a list in the configuration file.