Start #26
Merged
Start #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-akers
approved these changes
Nov 9, 2023
r-akers
approved these changes
Nov 9, 2023
ghost
suggested changes
Nov 9, 2023
ghost
suggested changes
Nov 10, 2023
| net.install(root) | ||
| kp.install(root) | ||
| # netplan | ||
| netplan = net.Netplan(file) |
There was a problem hiding this comment.
We've got this being defined in both run and this function. Remember DRY, can we either pass the modules instantiated in run into this function as arguments or otherwise define them as globals?
ghost
suggested changes
Nov 10, 2023
Closed
ghost
suggested changes
Nov 21, 2023
BBergle
approved these changes
Nov 21, 2023
ghost
approved these changes
Nov 23, 2023
patedm01
approved these changes
Nov 28, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.