OS Files Downloading Module #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HenrithicusGreenson
commented
Nov 1, 2023
- Updated comment in nat.py to be correct
- Created os_file_download.py
- Updated comment in nat.py to be correct - Created os_file_download.py
ghost
reviewed
Nov 2, 2023
ghost
reviewed
Nov 2, 2023
ghost
reviewed
Nov 2, 2023
- Updated base.py to use Robert's changes. - Added requests.py to Poetry build - Updated os_file_download to use the install method instead of setup_commands.
Closed
Addressed several linter complaints:
Reduced line length by shortening comments and breaking down longer lines.
Used class-level comments (''' ''') for the class description.
Addressed missing timeout argument in requests.get to prevent indefinite hanging.
Reordered imports according to the linting suggestions.
Corrected indentation issues.
Added a final newline at the end of the file as recommended by the linter.
…e and version selections for Debian. - Added version-name and target-architecture variables to example yml file for use in the os_file_downloads file. - Used said variables in the download link for the debian tar file.
- Will need to figure out automation of installer prompts later...
|
Reverted back to minimum viable product, will work on netboot.xyz integration in a separate PR. |
ghost
approved these changes
Nov 13, 2023
r-akers
approved these changes
Nov 13, 2023
…etter cross-platform support
patedm01
approved these changes
Nov 16, 2023
BBergle
approved these changes
Nov 17, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.