Setup Commands #14
Merged
Setup Commands #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added my run commands to the nat.py file |
ghost
commented
Oct 25, 2023
r-akers
approved these changes
Oct 26, 2023
Closed
HenrithicusGreenson
approved these changes
Oct 26, 2023
BBergle
approved these changes
Oct 26, 2023
…the running configuration
ghost
commented
Oct 26, 2023
…f instead of the redirect operator
patedm01
approved these changes
Oct 27, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function to the Module base class. The purpose of this function is to generate the executable and arguments that are needed to finish any setup for the module, ex. restart affected services. The function returns a list of commands that the calling function can then pass to the system to execute and/or display to the user. Ideally, the commands will be ran when the user calls
genisys installand printed to the terminal (or possibly a file) when the user callsgenisys generate. We may want to extend the command line specification to allow the user to prevent running these commands when installing.This function does not need to be implemented for all subclasses. The default behavior is the return an empty list, which the calling function should then ignore.