-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meteor ansible integration #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents blocking caused by .run
Potentially could cause a future issue if new playbooks need to be added, could need
Not really, just not sure what the meteor way of grabbing the selected option from the selection box is so we're rockin with the .closest call
…nventory file Now ready for testing
Also added inventory file creation to startup command instead of method call Also changed structure of inventory file to better reflect what we're actually trying to do.
…or/genisys into meteor-ansible-integration
Updated genisys inventory to include a provisioned field. Added delete host button to UI w/ functionality.
…ods in separate file
In light of recent CVEs, having compressed/unauditable files in repo is probably not a good idea.
- Currently doesn't get any output from the ansible commands for some reason, still troubleshooting
BBergle
approved these changes
Apr 8, 2024
xeluior
reviewed
Apr 8, 2024
event.preventDefault() | ||
|
||
//Talk to will about the meteor way of doing this: | ||
const selectedOption = $(event.currentTarget) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JQuery? Where is $ imported from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I see online it looks like jQuery is included globally by default in Meteor projects.
xeluior
approved these changes
Apr 8, 2024
r-akers
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following: