Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add IR generation notebook #3881

Merged
merged 1 commit into from
Feb 12, 2025
Merged

docs: Add IR generation notebook #3881

merged 1 commit into from
Feb 12, 2025

Conversation

stack-info: PR: #3881, branch: math-fehr/stack/4
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (math-fehr/stack/8@0047b1e). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             math-fehr/stack/8    #3881   +/-   ##
====================================================
  Coverage                     ?   91.26%           
====================================================
  Files                        ?      466           
  Lines                        ?    57949           
  Branches                     ?     5575           
====================================================
  Hits                         ?    52886           
  Misses                       ?     3635           
  Partials                     ?     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

superlopuh commented Feb 11, 2025

It feels like we should update the test script to launch in a way that takes the dependencies into account.

@compor
Copy link
Collaborator

compor commented Feb 11, 2025

also, why are these stacked?

@math-fehr
Copy link
Collaborator Author

I stacked them because it's really simple for me to convert 4 commits into 4 PRs.
Otherwise there are no particular reasons

@compor
Copy link
Collaborator

compor commented Feb 11, 2025

what level of review are we interested in here? is it just to get them in and then iterate over?

For example, in this notebook I see there following:

2025-02-11-132549_771x191_scrot

i.e., no SymPy examples.

I don't remember this part in the Winter School, but is there supposed to be something there?
Unless it's the missing deps?

@math-fehr math-fehr force-pushed the math-fehr/stack/4 branch 2 times, most recently from 15905d7 to 3499e42 Compare February 11, 2025 13:32
@math-fehr math-fehr changed the base branch from main to math-fehr/stack/8 February 11, 2025 13:32
@math-fehr math-fehr changed the base branch from math-fehr/stack/8 to main February 11, 2025 13:39
@math-fehr math-fehr changed the base branch from main to math-fehr/stack/8 February 11, 2025 13:40
@math-fehr math-fehr changed the base branch from math-fehr/stack/8 to main February 11, 2025 13:41
@math-fehr math-fehr changed the base branch from main to math-fehr/stack/8 February 11, 2025 13:41
@math-fehr math-fehr changed the base branch from math-fehr/stack/8 to main February 11, 2025 13:43
@math-fehr math-fehr changed the base branch from main to math-fehr/stack/8 February 11, 2025 13:43
@math-fehr
Copy link
Collaborator Author

what level of review are we interested in here? is it just to get them in and then iterate over?

For example, in this notebook I see there following:

2025-02-11-132549_771x191_scrot

i.e., no SymPy examples.

I don't remember this part in the Winter School, but is there supposed to be something there? Unless it's the missing deps?

I fixed this here, but overall I don't really have much time to fix all these things because of the PLDI rebuttal. The plan is to just have something we can CI check, and we can clean things bit by bit

@math-fehr math-fehr changed the base branch from math-fehr/stack/8 to main February 11, 2025 13:45
@math-fehr math-fehr changed the base branch from main to math-fehr/stack/8 February 11, 2025 13:46
@superlopuh
Copy link
Member

superlopuh commented Feb 11, 2025

Fixes #3857 (needs to be added to description)

@superlopuh superlopuh linked an issue Feb 11, 2025 that may be closed by this pull request
Base automatically changed from math-fehr/stack/8 to main February 12, 2025 12:22
@math-fehr math-fehr requested a review from superlopuh February 12, 2025 12:26
@math-fehr math-fehr merged commit f817ceb into main Feb 12, 2025
16 checks passed
@math-fehr math-fehr deleted the math-fehr/stack/4 branch February 12, 2025 13:29
math-fehr added a commit that referenced this pull request Feb 12, 2025
Stacked PRs:
 * __->__#3884
 * #3883
 * #3882
 * #3881
 * #3886


--- --- ---

### docs: Add notebook for defining dialects
oluwatimilehin pushed a commit to oluwatimilehin/xdsl that referenced this pull request Feb 13, 2025
oluwatimilehin pushed a commit to oluwatimilehin/xdsl that referenced this pull request Feb 13, 2025
Stacked PRs:
 * __->__#3884
 * xdslproject#3883
 * xdslproject#3882
 * xdslproject#3881
 * xdslproject#3886


--- --- ---

### docs: Add notebook for defining dialects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation: migrate ir_gen notebook from winter school
3 participants