Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (onnx) remove ONNX-related code #3738

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

superlopuh
Copy link
Member

ONNX, which I was hoping would be a convenient way to define NNs in Python to then compile using xDSL, has proven to be a massive maintenance burden, and generally not very good. They are slow to support new Python versions, poor typing support, and the import mechanism is not very stable, so I couldn't even reliably import networks. Our code for it is fairly buggy, and the bug fixes weren't all merged before Kayode finished his masters project.

Given Quidditch and IREE's support for importing ONNX, I don't see the point of having our implementation in xDSL, hence this PR.

@superlopuh superlopuh added the dialects Changes on the dialects label Jan 11, 2025
@superlopuh superlopuh self-assigned this Jan 11, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (e8de136) to head (4dc04c5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3738      +/-   ##
==========================================
- Coverage   91.29%   91.24%   -0.06%     
==========================================
  Files         467      458       -9     
  Lines       58544    57266    -1278     
  Branches     5649     5529     -120     
==========================================
- Hits        53449    52252    -1197     
+ Misses       3647     3588      -59     
+ Partials     1448     1426      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh superlopuh merged commit e30ec3b into main Jan 13, 2025
16 checks passed
@superlopuh superlopuh deleted the sasha/misc/remove-onnx branch January 13, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants