dialects: (builtin) Fix documentation for parsing of bools, and add conversion to Python bool

tests/dialects/test_builtin.py

@@ -167,6 +167,11 @@ def test_IntegerAttr_normalize():
         IntegerAttr(256, 8)
 
 
+def test_IntegerAttr_to_bool():
+    assert not IntegerAttr.from_bool(False)
+    assert IntegerAttr.from_bool(True)
+
+
 def test_IntegerType_packing():
     # i1
     nums_i1 = (0, 1, 0, 1)

xdsl/backend/csl/print_csl.py

@@ -800,9 +800,9 @@ def print_block(self, body: Block):
                         f"  .{q_type}_queue = @get_{q_type}_queue({queue_id.value.data}),"
                     )
                     self.print(f"  .fabric_color = {fabric_color},")
-                    if wavelet_index_offset:
+                    if wavelet_index_offset is not None:
                         self.print(f"  .wavelet_index_offset = {wavelet_index_offset},")
-                    if control:
+                    if control is not None:
                         self.print(f"  .control = {control},")
                     self.print("}});")
                 case csl.SetDsdBaseAddrOp(

xdsl/dialects/builtin.py

@@ -294,6 +294,10 @@ def print_parameter(self, printer: Printer) -> None:
         with printer.in_angle_brackets():
             printer.print_string(f"{self.data}")
 
+    def __bool__(self) -> bool:
+        """Returns True if value is non-zero."""
+        return bool(self.data)
+
 
 class Signedness(Enum):
     "Signedness semantics for integer"
@@ -705,6 +709,10 @@ def constr(
             ),
         )
 
+    def __bool__(self) -> bool:
+        """Returns True if value is non-zero."""
+        return bool(self.value)
+
 
 AnyIntegerAttr: TypeAlias = IntegerAttr[IntegerType | IndexType]
 AnyIntegerAttrConstr: BaseAttr[AnyIntegerAttr] = BaseAttr(IntegerAttr)

xdsl/parser/attribute_parser.py

@@ -910,7 +910,7 @@ def _parse_typed_integer(
         """
         Parse an (possible negative) integer. The integer can
         either be decimal or hexadecimal.
-        Optionally allow parsing of 'true' or 'false' into 1 and 0.
+        Optionally allow parsing of 'true' or 'false' into -1 and 0.
         """
 
         pos = self.pos

xdsl/parser/base_parser.py

@@ -45,7 +45,7 @@ def parse_optional_integer(
         """
         Parse an (possible negative) integer. The integer can either be
         decimal or hexadecimal.
-        Optionally allow parsing of 'true' or 'false' into 1 and 0.
+        Optionally allow parsing of 'true' or 'false' into -1 and 0.
         """
         # Parse true and false if needed
         if allow_boolean:
@@ -78,7 +78,7 @@ def parse_integer(
         """
         Parse an (possible negative) integer. The integer can
         either be decimal or hexadecimal.
-        Optionally allow parsing of 'true' or 'false' into 1 and 0.
+        Optionally allow parsing of 'true' or 'false' into -1 and 0.
         """
 
         return self.expect(
@@ -121,7 +121,7 @@ def parse_optional_number(
     ) -> int | float | None:
         """
         Parse a (possibly negative) integer or float literal, if present.
-        Can optionally parse 'true' or 'false' into 1 and 0.
+        Can optionally parse 'true' or 'false' into -1 and 0.
         """
 
         is_negative = self._parse_optional_token(MLIRTokenKind.MINUS) is not None
@@ -149,7 +149,7 @@ def parse_number(
     ) -> int | float:
         """
         Parse a (possibly negative) integer or float literal.
-        Can optionally parse 'true' or 'false' into 1 and 0.
+        Can optionally parse 'true' or 'false' into -1 and 0.
         """
         return self.expect(
             lambda: self.parse_optional_number(allow_boolean=allow_boolean),