[WIP]: Proof of concept going from jax to riscv #3674
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
=======================================
Coverage 91.29% 91.30%
=======================================
Files 466 467 +1
Lines 58357 58410 +53
Branches 5624 5631 +7
=======================================
+ Hits 53278 53331 +53
Misses 3629 3629
Partials 1450 1450 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Dec 26, 2024
Comment on lines
+31
to
+35
| donated_inputs = [ | ||
| inp | ||
| for inp, attr in zip(func_op.args, func_op.arg_attrs, strict=True) | ||
| if isinstance(inp.type, TensorType) and "tf.aliasing_output" in attr.data | ||
| ] |
There was a problem hiding this comment.
let's use a tuple for this, and bail out if this is empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.