Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (csl) Switch dsds to use affine maps #3657

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Dec 19, 2024

No description provided.

@n-io n-io added the dialects Changes on the dialects label Dec 19, 2024
@n-io n-io self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (d5dd188) to head (d0f22a7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
+ Coverage   90.73%   90.75%   +0.02%     
==========================================
  Files         467      467              
  Lines       59010    59141     +131     
  Branches     5650     5661      +11     
==========================================
+ Hits        53540    53671     +131     
  Misses       4022     4022              
  Partials     1448     1448              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io marked this pull request as ready for review December 19, 2024 12:18
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Could you also please add a test case (in the backend filecheck) to test for mem1d_dsd accessing a 2d array?

@n-io n-io requested a review from dk949 December 19, 2024 12:41
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n-io n-io merged commit 48642de into main Dec 19, 2024
16 checks passed
@n-io n-io deleted the nicolai/affine-map-dsds branch December 19, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants