Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (csl-stencil-bufferize) Inject accumulator in all csl-stencil linalg ops #3343

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Oct 25, 2024

This is in preparation for one-shot-bufferize and significantly reduces the number of intermediate buffer allocations we need to keep.

@n-io n-io added the transformations Changes or adds a transformatio label Oct 25, 2024
@n-io n-io self-assigned this Oct 25, 2024
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just don't get one part, other than that, all looks good

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (a3e2e7c) to head (f57d0b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
- Coverage   90.08%   90.07%   -0.01%     
==========================================
  Files         446      446              
  Lines       56419    56440      +21     
  Branches     5417     5425       +8     
==========================================
+ Hits        50824    50840      +16     
- Misses       4162     4164       +2     
- Partials     1433     1436       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io merged commit 8c332bd into main Oct 25, 2024
14 checks passed
@n-io n-io deleted the nicolai/bufferization-inject-accumulator-more branch October 25, 2024 19:12
EdmundGoodman pushed a commit to EdmundGoodman/xdsl that referenced this pull request Dec 6, 2024
…l-stencil linalg ops (xdslproject#3343)

This is in preparation for `one-shot-bufferize` and significantly
reduces the number of intermediate buffer allocations we need to keep.

---------

Co-authored-by: n-io <n-io@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants