transformations: (lower-csl-stencil) Check isBorderRegionPE #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 tasks
AntonLydike
approved these changes
Sep 26, 2024
| PatternRewriteWalker( | ||
| LowerYieldOp(), |
There was a problem hiding this comment.
Can these two rewrites not be applied in one pass? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
csl_stencil.apply.done_exchangeregion is wrapped in an check toisBorderRegionPE, such that the compute and (most importantly) the store do not happen for PEs of the border region. While technically possible to wrap only the store, it may be beneficial for code optimisation to wrap all rather than wrap minimally.