Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Refactor irdl_op_definition #2575

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

math-fehr
Copy link
Collaborator

Refactor get_accessors_from_op_def out of irdl_op_definition, towards allowing us to define new Python classes with only an OpDef, rather than an irdl_op_definition

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.64%. Comparing base (c566b0d) to head (046fd0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
- Coverage   89.64%   89.64%   -0.01%     
==========================================
  Files         357      357              
  Lines       45165    45169       +4     
  Branches     6790     6791       +1     
==========================================
+ Hits        40490    40492       +2     
- Misses       3655     3656       +1     
- Partials     1020     1021       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label May 13, 2024
@math-fehr math-fehr merged commit d09b184 into main May 13, 2024
10 checks passed
@math-fehr math-fehr deleted the fehr/irdl-op-def-with-opdef branch May 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants