Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: properties in declarative format #2031

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

math-fehr
Copy link
Collaborator

This PR enables properties in the declarative format.

By default, all properties should be specified in the format.
However, with the ParsePropInAttrDict IRDL option, properties are instead parsed by the attribute dictionary, to keep compatibility with MLIR.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Jan 26, 2024
@math-fehr math-fehr self-assigned this Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6e0975f) 90.01% compared to head (ecc7a63) 90.03%.

Files Patch % Lines
xdsl/irdl/declarative_assembly_format_parser.py 73.91% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
+ Coverage   90.01%   90.03%   +0.01%     
==========================================
  Files         291      291              
  Lines       36283    36337      +54     
  Branches     5381     5394      +13     
==========================================
+ Hits        32660    32715      +55     
  Misses       2851     2851              
+ Partials      772      771       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

should this be based on the other PR?

@math-fehr math-fehr force-pushed the fehr/prop-declarative-format branch from 28f16d3 to 3753e98 Compare January 26, 2024 18:08
@math-fehr
Copy link
Collaborator Author

Good point, done now

@math-fehr math-fehr merged commit 1ee55fd into main Jan 30, 2024
10 checks passed
@math-fehr math-fehr deleted the fehr/prop-declarative-format branch January 30, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants