Prove Postgres cache store has bug with integration test #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdevor
pushed a commit
that referenced
this pull request
Jun 5, 2024
…e string, null given (laravel#49467) * + Added test that reproduces bug * + Added fix that resolves bug * Update src/Illuminate/Filesystem/functions.php Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com> * Update src/Illuminate/Filesystem/functions.php Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com> * ~ Don't explicitly test for null --------- Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prove that postgres as cache store has bug with integration test
bug ref: laravel#48968