Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some other mark fails #16

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Fixed some other mark fails #16

merged 9 commits into from
Nov 28, 2023

Conversation

RosaWagner
Copy link
Contributor

Hi @xconsau, a new check in fontbakery allowed to spot some issues with diacrticis which we need to fix due to this problem with the API: google/fonts#6542

This method of using anchors and automatic alignment forces a more rational and consistent accent positioning. Using component for accented letters also highlighted inconsistencies between the base letter and and accented letter.
I tried to respect as much as possible the position of the previous accents but you can see some slight shifts in the diff which I link below due to the nature of this accent building method.

out.zip

If you are okay with these chnages, you can merge and I'll onboard the update in GF.

@xconsau xconsau merged commit b1c41a8 into xconsau:master Nov 28, 2023
@xconsau
Copy link
Owner

xconsau commented Nov 28, 2023

Hi Rosalie,

Thanks very much for the PR and your time on the font. The accents are looking better aligned now. I also went through the thread you have mentioned about the API check. I agree that the component system with mark positioning is more consistent as compared to a decomposed character. Also thank you for updating the feature files and binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants