Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log compound names when alignment is not found (issue 1495) #651

Merged
merged 1 commit into from
Sep 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion viewer/cset_upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,18 @@ def set_mol(
# find distances between corresponding atoms of the
# two conformers. if any one exceeds the _DIST_LIMIT,
# consider it to be a new ComputedMolecule
_, _, atom_map = Chem.rdMolAlign.GetBestAlignmentTransform(mol, kmol)
try:
_, _, atom_map = Chem.rdMolAlign.GetBestAlignmentTransform(
mol, kmol
)
except RuntimeError as exc:
msg = (
f'Failed to find alignment between {k.molecule_name} '
+ f'and {mol.GetProp("original ID")}'
)
logger.error(msg)
raise RuntimeError(msg) from exc

molconf = mol.GetConformer()
kmolconf = kmol.GetConformer()
small_enough = True
Expand Down