Skip to content

Commit

Permalink
Fix connection failure logic (#604)
Browse files Browse the repository at this point in the history
* refactor: Adds extra logging in proposal extraction

* style: Initial cache now a set rather than empty list

* fix: Fix cache collection failure logic

---------

Co-authored-by: Alan Christie <alan.christie@matildapeak.com>
  • Loading branch information
alanbchristie and Alan Christie authored May 30, 2024
1 parent aa8cc22 commit 392d1bf
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion api/security.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ def _get_proposals_for_user_from_ispyb(self, user):
self._get_proposals_from_connector(user, conn)
else:
logger.warning("Failed to get a connector for '%s'", user.username)
self._mark_cache_collection_failure(user)
else:
PrometheusMetrics.new_proposal_cache_hit()

Expand Down

0 comments on commit 392d1bf

Please sign in to comment.