Fixes for custom buttons #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First option is to simply not dequeue and always load fresh cell. Second option is to only do refresh for the custom buttons (as done in the old code before unifying the nib-loading). Due to refactoring this now adds more code. In case we want to keep this, I can move the doubled up variable initialization into a helper method. |
|
I guess second option is the last commit. Let's go with the first option then (the old way, if I get it right). |
|
The "old way" was more like the 2nd option (last commit). But the simpler workaround is 1st option, which I personally prefer. If you agree, I will just remove the last commit. I'll keep #836 open as I would need your help to find a proper solution. We can discuss it there. |
This fixes a layout issue after sleep / resume.
24955e5 to
208cd0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #836 there is still a problem with the layout after sleep / resume cell in
RightMenuViewController. The former code also was not using dequeueing but loaded the cell fresh each time. To unblock the release 1.12 I propose a workaround which again loads the custom button rows each time when enteringcellForRowAtIndexPath.This needs another rework in future.
Summary for release notes
Bugfix: Improve readability of button rename icon in light mode
Bugfix: Fix custom button layout problems after sleep / resume