Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements around recordings (needs Kodi Nexus) #543

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Improvements around recordings (needs Kodi Nexus) #543

merged 3 commits into from
Jan 7, 2022

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented Jan 5, 2022 •
edited
Loading

Description

Closes #430.

With Kodi Nexus (API 12.7.0) the handling of recordings was improved. This allows to add recordingid to Playlist.Insert and Playlist.Add. This fixes multiple problems:

  • Now playcount increases when recording playback is triggered from the App
  • The correct recording name is shown in the UI (before the file name was shown)
  • Icon art and plot is provided when asking for "Playlist.GetItems"

With this the App now again supports sorting by playcount. In addition, the NowPlaying screen and the Playlist will use icon art (typically the broadcast station logo).

Screenshots:

Summary for release notes

Improvements around recordings (needs Kodi Nexus)

@wutschel wutschel marked this pull request as draft January 5, 2022 19:41
@wutschel wutschel changed the title Improvement: Improvements around recordings (needs Kodi Nexus) Jan 5, 2022
@wutschel
Copy link
Collaborator Author

wutschel commented Jan 5, 2022

Still need to check the background color for the station logo thumbs.

@wutschel
Copy link
Collaborator Author

wutschel commented Jan 6, 2022

@phunkyfish, fyi

kambala-decapitator
kambala-decapitator reviewed Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@kambala-decapitator kambala-decapitator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine at this point, but I haven't made runtime test.

An idea for another PR: add helper methods to check for API versions? Like isMatrix and isAtLeast x.y.z.

@wutschel
Copy link
Collaborator Author

wutschel commented Jan 7, 2022

An idea for another PR: add helper methods to check for API versions? Like isMatrix and isAtLeast x.y.z.

Yes, good idea. I'll create an issue as a reminder.

@wutschel
Improved recordingid support since API 12.7.0
3c67e66 
Since API 12.7.0 Playlist.Insert and Playlist.Add supports "recordingid". From this API on we can remove the workaround to add/insert file paths.
@wutschel
NowPlaying and Playlist use icon art when playing a recording
f192fe4 
Since API 12.7.0 the item type "recording" is supported. In this case use the icon art (typically the station logo) as thumbnail for playlist and NowPlaying screen.
@wutschel
Add playcount to recording action sheet
e209dd4
@wutschel wutschel marked this pull request as ready for review January 7, 2022 16:14
@wutschel
Copy link
Collaborator Author

wutschel commented Jan 7, 2022

Squashed and rebased to master.

@kambala-decapitator kambala-decapitator merged commit 14dc0f1 into xbmc:master Jan 7, 2022
@wutschel wutschel deleted the play_recordingid branch January 7, 2022 16:20
@wutschel wutschel mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kambala-decapitator kambala-decapitator kambala-decapitator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special treatment for PVR recordings causes loss of features
2 participants
@wutschel @kambala-decapitator