Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove unused string from localization #1232

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Maintenance: Remove unused string from localization #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c681729
Remove unused strings from localization
wutschel Jan 13, 2025
9feba2e
Only use a unique string for the scrabbing rate
wutschel Jan 19, 2025
78ba741
Rework logic to identify "resume" in actionSheetHandler
wutschel Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion XBMC Remote/NowPlaying.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2807,7 +2807,7 @@ - (void)viewDidLoad {
[ProgressSlider setThumbImage:[UIImage new] forState:UIControlStateNormal];
[ProgressSlider setThumbImage:[UIImage new] forState:UIControlStateHighlighted];
ProgressSlider.hidden = YES;
scrabbingMessage.text = LOCALIZED_STR(@"Slide your finger up to adjust the scrubbing rate.");
scrabbingMessage.text = LOCALIZED_STR(@"Slide your finger up or down to adjust the scrubbing rate.");
scrabbingRate.text = LOCALIZED_STR(@"Scrubbing 1");
sheetActions = [NSMutableArray new];
currentPlaylistID = PLAYERID_UNKNOWN;
Expand Down
3 changes: 2 additions & 1 deletion XBMC Remote/ShowInfoViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ - (void)showActionSheet {
}

- (void)actionSheetHandler:(NSString*)actiontitle {
NSString *resumeKey = [LOCALIZED_STR(@"Resume from %@") stringByReplacingOccurrencesOfString:@"%@" withString:@""];
if ([actiontitle isEqualToString:LOCALIZED_STR(@"Queue after current")]) {
[self addQueueAfterCurrent:YES];
}
Expand All @@ -401,7 +402,7 @@ - (void)actionSheetHandler:(NSString*)actiontitle {
[actiontitle isEqualToString:LOCALIZED_STR(@"Stop Recording")]) {
[self recordChannel];
}
else if ([actiontitle rangeOfString:LOCALIZED_STR(@"Resume from")].location != NSNotFound) {
else if ([actiontitle rangeOfString:resumeKey].location != NSNotFound) {
[self resumePlayback];
}
else if ([actiontitle isEqualToString:LOCALIZED_STR(@"Play Trailer")]) {
Expand Down
30 changes: 0 additions & 30 deletions XBMC Remote/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,14 @@
"Pictures Add-ons" = "Pictures Add-ons";

"Power off System" = "Power off System";
"Power off" = "Power off";
"Hibernate" = "Hibernate";
"Suspend" = "Suspend";
"Reboot" = "Reboot";
"Quit XBMC application" = "Quit Kodi application";
"Update Audio Library" = "Update Audio Library";
"Update Audio" = "Update Audio";
"Clean Audio Library" = "Clean Audio Library";
"Clean Audio" = "Clean Audio";
"Update Video Library" = "Update Video Library";
"Update Video" = "Update Video";
"Clean Video Library" = "Clean Video Library";
"Clean Video" = "Clean Video";
"Quit" = "Quit";

"Keyboard" = "Keyboard";
"Gesture Zone" = "Gesture Zone";
Expand Down Expand Up @@ -100,12 +94,10 @@

"Playlist" = "Playlist";
"Details not found" = "Details not found";
"Open in Safari" = "Open in Safari";
"Error loading page" = "Error loading page";
"OK" = "OK";
"Cancel" = "Cancel";
"Resume from %@" = "Resume from %@";
"Resume from" = "Resume from";
"First aired on %@" = "First aired on %@";
"Episodes: %@" = "Episodes: %@";
"1 result" = "1 result";
Expand All @@ -129,15 +121,6 @@
"Are you sure you want to clear the music playlist?" = "Are you sure you want to clear the music playlist?";
"Are you sure you want to clear the video playlist?" = "Are you sure you want to clear the video playlist?";
"Are you sure you want to clear the picture playlist?" = "Are you sure you want to clear the picture playlist?";
"Are you sure you want to power off your XBMC system now?" = "Are you sure you want to power off your Kodi system now?";
"Are you sure you want to hibernate your XBMC system now?" = "Are you sure you want to hibernate your Kodi system now?";
"Are you sure you want to suspend your XBMC system now?" = "Are you sure you want to suspend your Kodi system now?";
"Are you sure you want to reboot your XBMC system now?" = "Are you sure you want to reboot your Kodi system now?";
"Are you sure you want to quit XBMC application now?" = "Are you sure you want to quit Kodi application now?";
"Are you sure you want to update your audio library now?" = "Are you sure you want to update your audio library now?";
"Are you sure you want to clean your audio library now?" = "Are you sure you want to clean your audio library now?";
"Are you sure you want to update your video library now?" = "Are you sure you want to update your video library now?";
"Are you sure you want to clean your video library now?" = "Are you sure you want to clean your video library now?";

"DIRECTED BY" = "DIRECTED BY";
"RUNTIME" = "RUNTIME";
Expand All @@ -162,11 +145,6 @@
"BORN / FORMED" = "BORN / FORMED";
"TRAILER" = "TRAILER";

"codec" = "codec";
"bit rate" = "bit rate";
"sample rate" = "sample rate";
"resolution" = "resolution";
"aspect ratio" = "aspect ratio";
"Subtitles not available" = "Subtitles not available";
"Audiostream not available" = "Audio stream not available";
"Audiostreams not available" = "Audio streams not available";
Expand All @@ -181,7 +159,6 @@
"vote" = "vote";
"votes" = "votes";

"Slide your finger up to adjust the scrubbing rate." = "Slide your finger up to adjust the scrubbing rate.";
"Scrubbing 1" = "Hi-Speed Scrubbing";
"Scrubbing 0.5" = "Half-Speed Scrubbing";
"Scrubbing 0.25" = "Quarter-Speed Scrubbing";
Expand Down Expand Up @@ -248,11 +225,9 @@
"XBMC \"Gotham\" version 13 or superior is required to access XBMC settings" = "Kodi version 13 or superior is required to access Kodi settings";
"-- WARNING --\nThis kind of setting cannot be configured remotely. Use the XBMC GUI for changing this setting.\nThank you." = "-- WARNING --\nThis kind of setting cannot be configured remotely. Use the Kodi GUI for changing this setting.\nThank you.";

"Official Kodi Remote app uses artwork downloaded from your Kodi server or from the internet when your Kodi server refers to it. To unleash the beauty of artwork use Kodi's \"Universal Scraper\" or other scraper add-ons.\n\nKodi logo, Zappy mascot and Official Kodi Remote icons are property of Kodi Foundation.\nhttp://www.kodi.tv/contribute\n\n - Team Kodi" = "Official Kodi Remote app uses artwork downloaded from your Kodi server or from the internet when your Kodi server refers to it. To unleash the beauty of artwork use Kodi's \"Universal Scraper\" or other scraper add-ons.\n\nKodi logo, Zappy mascot and Official Kodi Remote icons are property of Kodi Foundation.\nhttp://www.kodi.tv/contribute\n\n - Team Kodi";
"Official Kodi Remote app uses artwork downloaded from your Kodi server or from the internet when your Kodi server refers to it. To unleash the beauty of artwork use Kodi's \"Universal Scraper\" or other scraper add-ons.\n\nKodi logo and Official Kodi Remote icons are property of Kodi Foundation.\nhttp://www.kodi.tv/contribute\n\n - Team Kodi" = "Official Kodi Remote app uses artwork downloaded from your Kodi server or from the internet when your Kodi server refers to it. To unleash the beauty of artwork use Kodi's \"Universal Scraper\" or other scraper add-ons.\n\nKodi logo and Official Kodi Remote icons are property of Kodi Foundation.\nhttp://www.kodi.tv/contribute\n\n - Team Kodi";

"No items found." = "No items found.";
"Video" = "Video";
"Party" = "Party";
"Search" = "Search";

Expand Down Expand Up @@ -282,8 +257,6 @@
"Password" = "Password";

"Sort by" = "Sort by";
"tap" = "tap";
"the selection" = "the selection";
"tap the selection\nto reverse the sort order" = "tap the selection\nto reverse the sort order";
"Not listened" = "Not listened";
"Listened one time" = "Listened one time";
Expand All @@ -300,7 +273,6 @@
"Duration" = "Duration";
"Date added" = "Date added";
"Name" = "Name";
"User rating" = "User rating";
"The %@s decade" = "The %@s decade";
"Year not available" = "Year not available";
"Year %@" = "Year %@";
Expand Down Expand Up @@ -348,8 +320,6 @@
"Last Updated: %@" = "Last Updated: %@";
"Never" = "Never";

"For search switch to list view" = "For search switch to list view";

"Channel" = "Channel";
"Date" = "Date";
"Runtime" = "Runtime";
Expand Down