Rework messages to centralized approach #1109
Conversation
5c4a92b to
7d3eeb1
Compare
XBMC Remote/ViewControllerIPad.m
Outdated
| [[NSNotificationCenter defaultCenter] addObserver: self | ||
| selector: @selector(showNotificationMessage:) | ||
| name: @"AudioLibrary.OnScanFinished" | ||
| object: nil]; | ||
|
|
||
| [[NSNotificationCenter defaultCenter] addObserver: self | ||
| selector: @selector(showNotificationMessage:) | ||
| name: @"AudioLibrary.OnCleanFinished" | ||
| object: nil]; | ||
|
|
||
| [[NSNotificationCenter defaultCenter] addObserver: self | ||
| selector: @selector(showNotificationMessage:) | ||
| name: @"VideoLibrary.OnScanFinished" | ||
| object: nil]; | ||
|
|
||
| [[NSNotificationCenter defaultCenter] addObserver: self | ||
| selector: @selector(showNotificationMessage:) | ||
| name: @"VideoLibrary.OnCleanFinished" | ||
| object: nil]; | ||
|
|
||
| [[NSNotificationCenter defaultCenter] addObserver: self | ||
| selector: @selector(showNotificationMessage:) | ||
| name: @"UIShowMessage" | ||
| object: nil]; |
There was a problem hiding this comment.
- copy-pasted
- rather loop through an array of notification names
There was a problem hiding this comment.
If you don't object, I would like to keep this. This way the notifications are all listed in one block and easy to read and oversee. If I now introduce a dedicated method or loop, it is not that straight forward anymore.
There was a problem hiding this comment.
not sure how using a loop makes it less straightforward :)
NSArray* notificationsWithMessage = @[
@"AudioLibrary.OnScanFinished",
...
];
for (NSString* notificationWithMessage in notificationsWithMessage) {
[NSNotificationCenter.defaultCenter addObserver: self
selector:@selector(showNotificationMessage:)
name:notificationWithMessage
object:nil];
}There was a problem hiding this comment.
I know what you meant, I just find this less straight forward to oversee in a block of other addObserver calls which all follow the same pattern.
Maybe we just look different at the code. :)
There was a problem hiding this comment.
Alternatively you can create base class for those 2 view controllers and place this code in there. Also move other common things there (I believe there're some)
There was a problem hiding this comment.
Hmm, interesting thought. There really might be some common code ... Ok to do this separately?
There was a problem hiding this comment.
Hmm, interesting thought. There really might be some common code ... Ok to do this separately?
Sure, that's fine
7d3eeb1 to
1a498cd
Compare
As we can now trigger library scan/clean from several view the messages are now shown by the central view controllers for iPad and iPhone. The implementation inside RightMenuVC is obsolete.
Instead of using a dedicated instance per UIViewController only send a notification which is picked by the central controllers for iPad/iPhone. This central controller will handle displaying all messages.
Move existing helper method topMostController to Utilities and re-use also for placing the messagesView.
bc841fd to
b332902
Compare
|
Nicely squashed and rebased. |
Description
This PR reworks the approach on how messages are shown. Before, each
UIViewControllerhad an own instance ofMessagesViewand the messages were presented by it. Now, there is only a single instance ofMessagesViewin either the iPad's or iPhone's main controller. All otherUIVewControllers send notifications which are consumed by this central instance and shown from there. This allows to reduce code to layout and create several instances and it easily aligns the layout of the messages.In addition, this PR brings back the messages after executing action from the "Power Menu" (e.g. Audio Library Scan). Those were lost as part of refactoring and unifying the power menu.
Summary for release notes
Maintenance: Use centralized approach to show messages
Bugfix: Show power menu related messages again