Fix adaptive icon foreground dimensions #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Never noticed this on my devices... I need a new phone ;). |
poisdeux
approved these changes
Feb 18, 2019
|
Yeah, thanks for spotting this - i had wondered why the icon wasn't showing up right in the share panel, but didn't look into it. I'm going to merge this as is, but i think that the correct dimensions should be 108dp. But for that to work, the vector drawing needed to be restricted to the 72dp area inside that, and i'm not sure it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I found the foreground layer drawable is incorrectly sized which causes display issues in certain parts of the system settings. The correct size should be 72dp as per the adaptive icon documentation.
Here are some screenshots to show the effects of the change.
24dp vs 72dp on a Samsung Note 8
24dp vs 72dp inside Samsung Secure Folder
24dp on API 27 emulator
72dp on API 27 emulator
