Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device): fix Z2M mapping for Philips929003017102 #639

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

xaviml
Copy link
Owner

@xaviml xaviml commented Dec 8, 2022

This PR fixes problem mention in this comment: #616 (comment) from @Dennis-Q.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

@github-actions github-actions bot temporarily deployed to pull request December 8, 2022 15:10 Inactive
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 96% // Head: 96% // No change to project coverage 👍

Coverage data is based on head (37ce171) compared to base (191a58f).
Patch has no changes to coverable lines.

❗ Current head 37ce171 differs from pull request most recent head 23bce63. Consider uploading reports for the commit 23bce63 to get more accurate results

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #639   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        63     63           
  Lines      2590   2590           
===================================
  Hits       2486   2486           
  Misses      104    104           
Impacted Files Coverage Δ
apps/controllerx/cx_devices/philips.py 100% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xaviml xaviml force-pushed the fix/philips929003017102-z2m-mapping branch from 37ce171 to 23bce63 Compare December 8, 2022 15:12
@github-actions github-actions bot temporarily deployed to pull request December 8, 2022 15:13 Inactive
@xaviml xaviml merged commit ca0fe24 into main Dec 8, 2022
@xaviml xaviml deleted the fix/philips929003017102-z2m-mapping branch December 8, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant