[Bug] [UWP] Fix FontIcons alignment

[tonyhallett]

Description of Change

Correct icon positioning

Issues Resolved

• fixes [Bug] [UWP] FontIcons are not aligned correctly #8606

API Changes

None

None

Platforms Affected

• UWP

Behavioral/Visual Changes

Changes to being correctly positioned

Before/After Screenshots

Cannot do as doing pull request in browser.

Testing Procedure

Cannot test.

PR Checklist

• Targets the correct branch
• Tests are passing (or failures are unrelated)

[jsuarezruiz]

@tonyhallett Thanks for the contribution!. Could you include a sample in https://github.com/xamarin/Xamarin.Forms/tree/5.0.0/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared to validate it?

[jfversluis]

/azp run

[jfversluis]

Thank you so much for taking the time to contribute this @tonyhallett ! Like Javier said; if you could add a little sample to demonstrate that would be awesome. This way it's easier for us to verify the fix now and in the future for possible regressions. Thanks!

[tonyhallett]

I will see if can screenshot and assert pixels.

[jfversluis]

If you look at the Control Gallery project there are a lot of pages describing issues. Just a button or anything with a font icon on it that would be not properly aligned before this fix, but is properly aligned now will do :)

[tonyhallett]

@jfversluis Yes I saw a recent example that just added a control with a radial gradient. Is there snapshot testing occurring from these UI tests ?

[jfversluis]

UI tests run through App Center where we have the possibility to look at screenshots yes. Or we run some things manually for manual verification :)

[tonyhallett]

@jfversluis

Should I be creating screenshots ?
I did have the code below

#if UITEST 
using NUnit.Framework; using Xamarin.UITest; 
#endif 

#if UITEST 
[Test] public void ShouldHorizontallyCenterFontIcons() { 
RunningApp.WaitForElement(contentAutomationId); 
RunningApp.AttachScreenshotToTestContext("GithubIssue606"); } 
#endif

but If I ran the test from Visual Studio Test Explorer the init method was not called. Perhaps you can advise on that.

UI tests run through App Center where we have the possibility to look at screenshots yes. Or we run some things manually for manual verification :)

If I add a screenshot is there an automated test that will check future pull requests do not cause a regression ?

[jfversluis]

but If I ran the test from Visual Studio Test Explorer the init method was not called. Perhaps you can advise on that.

That is correct, this will run as a UI test rather than a unit test :)

Had a quick look and made some minor adjustments but other than that this seems good! Thanks!

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).