#13527 - OnAppearing() is now called on every back navigation again b… #13528
Conversation
…again by not storing the previous page in a variable, but managing all previous pages in a Stack<Page>
|
@jfversluis I just created the fix for the issue. Please comment |
| @@ -345,19 +345,23 @@ async void SetCurrent(Page newPage, bool popping = false, bool modal = false, Ac | |||
| Page previousPage = _currentPage; | |||
|
|
|||
| if (modal && !popping && !newPage.BackgroundColor.IsDefault) | |||
| _modalBackgroundPage = previousPage; | |||
There was a problem hiding this comment.
Because of this line, when you navigate to the second modal level, _modalBackgroundPage already has a value and will be overwritten.
As of that, when you navigate back the second time, _modalBackgroundPage will already be null (this is done in the first pop of the navigation stack at line 360 below!). So you lost the outer modal page and cannot call its OnAppeare() callback anymore!
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Alright, this seems good to me. Sorry we left this around for so long! Congrats on becoming a Xamarin.Forms contributor @gentledepp and many thanks for your time and effort on this! |
|
Any chance this "fix" has now broken navigation when using Shell.Current.GoToAsync(...) ? Whenever I call Shell.Current.GoToAsync(...) now, I get the new window for a second, then navigation returns to the primary window without further interaction. |
…y not storing the previous page in a variable, but managing all previous pages in a Stack
Description of Change
Issues Resolved
OnAppearing()callback of the previous page that you return to will only be called for the most inner level.E.g.: You have 3 modal pages: 1/2/3
navigating back from 3 to 2 will call 2.OnAppearing(), but navigating back from 2 to 1 will not call 1.OnAppearing() wich breaks a lot of things!
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist