Fix input for decimal/float/double and nullable #11815
Conversation
|
|
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Hello @rmarinho, may this caused by this line EDIT: This is caused, because the Decimal Separator in this culture is a ',' and not a '.' But the test tries to set to "0.5" instead of "0,5". |
|
In your UI tests, there's currently no way to know see the binding value or recognise if there was a binding error. You might want to add another control (maybe a label) that the displays the current value of my decimal so users can see what the entry is converting to and from in the tests. |
|
I have made an update to the UI Test. |
|
So whats the status on this PR? |
This commit fixes the input of decimal/float/double and their nullable equivalents in different cultures. Issue xamarin#7996
Makes the UI test more understandable. It shows now a label with the actual resolved binding value. In the entry you can now see the value you provided.
7a27f05 to
e9ee0cb
Compare
|
/azp run |
This comment has been minimized.
This comment has been minimized.
|
Hey @jonkas2211 I'm truly sorry this was kept around for so long. Just updated this to work with our latest code and see if I can get it to work. If you're still around and interested please let me know, if not, I will take over and see to get this merged. In either case: thank you so much for your time and effort on this. Although it doesn't show, I know I and all of use appreciate this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hello @jfversluis, |
|
Yeah from some quick testing it seems that the code looks alright, I had to fix up some old tests to take into account this new behavior. If you want, you could test this functionality on your own scenarios by downloading the NuGets that resulted from this build as described here. If you decide to do so, please let me know what you find, thanks! |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change
The input for floating numbers had some errors in different cultures.
When using german for example, the decimal seperator is a ',' and not a dot.
You can also use Nullable Types now. Before the Decimal Seperator would be cut off for Nullables.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
The user of an app can now use the correct decimal sperator for his language.
Before/After Screenshots
Not applicable
Testing Procedure
I have tested this on android.
I added a UI Test to the Gallery (G7996).
Unfortunately i cant test this on other platforms right now.
I also added a new Unit Test to prove the behaviour.
PR Checklist