- added comments

xamarin · Jun 17, 2022 · 59e567f · 59e567f
1 parent 4a5dce7
commit 59e567f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/Xamarin.Forms.Platform.Android/AppCompat/FlyoutPageRenderer.cs b/Xamarin.Forms.Platform.Android/AppCompat/FlyoutPageRenderer.cs
@@ -348,6 +348,9 @@ async void UpdateFlyoutLayoutBehavior(bool requestLayout = false)
 
 				if (Device.Idiom == TargetIdiom.Tablet && _flyoutLayout != null)
 				{
+					// This is required to add/remove the drawer button
+					// This basically runs the same code that runs when 
+					// a device changes between landscape/portrait
 					_detailLayout.GetFirstChildOfType<NavigationPageRenderer>()?.ResetToolbar();
 				}
 			}
@@ -400,6 +403,8 @@ void HandlePropertyChanged(object sender, PropertyChangedEventArgs e)
 			else if (e.PropertyName == VisualElement.FlowDirectionProperty.PropertyName)
 			{
 				UpdateFlowDirection();
+
+				// This will move the drawer layout button to the proper side of the toolbar
 				_detailLayout.GetFirstChildOfType<NavigationPageRenderer>()?.UpdateToolbar();
 			}
 			else if (e.Is(FlyoutPage.FlyoutLayoutBehaviorProperty))

diff --git a/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs b/Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs
@@ -983,6 +983,10 @@ internal void UpdateToolbar()
 					toggle.DrawerIndicatorEnabled = _flyoutPage.ShouldShowToolbarButton();
 					toggle.SyncState();
 
+					// When pivoting between split mode and flyout mode
+					// The DrawerArrowDrawable Progress will get out of sync and show a back button
+					// this forces it back to a hamburger
+
 					if (toggle.DrawerArrowDrawable != null)
 						toggle.DrawerArrowDrawable.Progress = 0;
 				}