Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't seem to filter Boolean values #378

Closed
1 task done
danchristian opened this issue Aug 30, 2018 · 2 comments
Closed
1 task done

Can't seem to filter Boolean values #378

danchristian opened this issue Aug 30, 2018 · 2 comments
Assignees
Labels

Comments

@danchristian
Copy link

  • Bug

What version are you using?
2.0.0.alpha

What browser?
Chrome

Expected Behavior

I can filter boolean values

Actual Behavior

I can't filter boolean values

jsfiddle

https://jsfiddle.net/ywdujp43/

@xaksis xaksis self-assigned this Aug 30, 2018
@xaksis xaksis added the bug label Aug 30, 2018
xaksis added a commit that referenced this issue Aug 30, 2018
@xaksis
Copy link
Owner

xaksis commented Aug 30, 2018

hey @danchristian thank you for pointing this out. This is now fixed in version 2.13.2

closing.

@xaksis xaksis closed this as completed Aug 30, 2018
@HudsonMCynner
Copy link

Hello, I found a solution to this problem, I added another IF condition in the Compare function inside the default.js file that is inside the folder.

I added this code : if (typeof d === 'boolean' ) return d;

compare(x, y) {

function cook(d) {

  if (typeof d === 'undefined' || d === null) return '';
  if (typeof d === 'boolean' ) return d;
  return d.toLowerCase();
}
x = cook(x);
y = cook(y);
if (x < y) return -1;
if (x > y) return 1;
return 0;

},
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants