Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [feature] Add support for Keypad sensors #90

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

xaf
Copy link
Owner

@xaf xaf commented Feb 19, 2023

Fixes #50

@xaf xaf added the enhancement New feature or request label Feb 19, 2023
@xaf xaf force-pushed the xaf/add_support_for_keypad_sensor branch from 10f92b7 to b00ffcf Compare February 19, 2023 03:22
@xaf xaf force-pushed the xaf/add_support_for_keypad_sensor branch from b00ffcf to add7c75 Compare February 19, 2023 03:26
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py240797%166, 214, 217, 336, 387, 467, 545
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%63–64, 66, 70, 75, 90–102, 112, 120, 146
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1952090%57–78, 136, 194, 198, 205, 222, 226
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL154114591% 

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 32.229s ⏱️

@xaf xaf merged commit 4bd1a0b into main Feb 19, 2023
@xaf xaf deleted the xaf/add_support_for_keypad_sensor branch February 19, 2023 03:31
@Anto79-ops
Copy link

Hi, just a question about this...not sure this is the right place to ask it.... I have 2 IQ Remotes, are these keypad sensors you are referring to here? if so,

  1. What does the state "safe" mean, and when does not it become safe?
  2. What defines a tamper for this sensor?

thanks

@xaf
Copy link
Owner Author

xaf commented Feb 22, 2023

  1. This sensor does not seem to change state nor update its state, hence why it is disabled by default and requires manual intervention to be added. I thus put the default "safety" device class for it, but it should not change state. I plan to use the "None" device class (no device class provided) soon-ish, but wanted to finish adding the extra disabled-by-default sensors before.
  2. I do not know if the sensor supports tamper updates or not, since they propagate the information through similar open/closed messages. Since you do have IQ Remotes, that would be interesting to figure that out (e.g. tamper could be when you open the IQ Remote maybe? Or maybe there's no supported tamper!)

I added support of that sensor from the data provided in #50 - I do not own that sensor unfortunately so have to base myself on the data provided to me!

@Anto79-ops
Copy link

thanks for clearing that up.

Interestingly, I do get tamper alerts from my IQ Remote about once ever 2 days. Which is strange because the remotes are not like the IQ Panel, when you can take the cover off etc. The remotes are sealed and fully fastened to the wall so there is no physical interference.

I'll see when if there is a pattern to the tampers.....might be related to disarming the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Keypad sensor type
2 participants