Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [bugfix] handle properly when to require a user code from HA #81

Merged

Conversation

xaf
Copy link
Owner

@xaf xaf commented Jan 20, 2023

The gateway was expecting a user code from Home Assistant as soon as a code was required for the action to be performed. However, when a panel code is defined in the gateway configuration, this code might not be required if not specifically required by the code_*_required flags. This fixes that.

Fixes #79

@xaf xaf added the bug Something isn't working label Jan 20, 2023
@github-actions

This comment has been minimized.

The gateway was expecting a user code from Home Assistant as soon
as a code was required for the action to be performed. However,
when a panel code is defined in the gateway configuration, this
code might not be required if not specifically required by the
`code_*_required` flags. This fixes that.
@xaf xaf force-pushed the xaf/code_disarm_required_and_ha_check_user_code_false_fail branch from 2550269 to 5e38b36 Compare January 20, 2023 23:02
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py239797%165, 213, 216, 335, 386, 465, 543
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%63–64, 66, 70, 75, 90–102, 112, 120, 146
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py2112091%57–78, 136, 194, 198, 205, 222, 226
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL155614591% 

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 31.735s ⏱️

@xaf xaf merged commit 76ccaa1 into main Jan 21, 2023
@xaf xaf deleted the xaf/code_disarm_required_and_ha_check_user_code_false_fail branch January 21, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion for improvement of ha_check_user_code documentation
1 participant