Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add disarm_failed counter as partition attribute #61

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

xaf
Copy link
Owner

@xaf xaf commented Jan 4, 2023

This counter will increase everytime we encounter a DISARM_FAILED error for the partition, and will reset when the partition is successfully disarmed.

Fixes #6

@xaf xaf added the enhancement New feature or request label Jan 4, 2023
@github-actions

This comment has been minimized.

@xaf xaf force-pushed the xaf/add_partition_disarm_failed_counter branch from eb1adda to b74e3d9 Compare January 4, 2023 16:34
@github-actions

This comment has been minimized.

@xaf xaf force-pushed the xaf/add_partition_disarm_failed_counter branch from b74e3d9 to 7fdf6fa Compare January 4, 2023 16:43
@github-actions

This comment has been minimized.

This counter will increase everytime we encounter a `DISARM_FAILED`
error for the partition, and will reset when the partition is
successfully disarmed.
@xaf xaf force-pushed the xaf/add_partition_disarm_failed_counter branch from 7fdf6fa to d8d65ad Compare January 4, 2023 16:46
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py80100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py2271494%184, 187, 214, 222, 227, 232, 236, 241, 273, 335, 340, 418, 460, 508
   utils.py200100% 
apps/qolsysgw/qolsys
   actions.py48296%24, 34
   config.py581181%58–59, 61, 65, 70, 85–97, 123
   control.py142795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%60, 65, 93, 97, 123–124, 156, 160, 183, 194, 201, 225, 241, 255, 268–270, 315, 347, 359, 404
   exceptions.py200100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1792288%51–72, 116, 120, 126, 155, 159, 164, 179, 183
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py50394%18, 52, 60
   utils.py32488%10, 13, 19–20
TOTAL145715290% 

Tests Skipped Failures Errors Time
97 0 💤 0 ❌ 0 🔥 24.377s ⏱️

@xaf xaf merged commit f0ef14e into main Jan 4, 2023
@xaf xaf deleted the xaf/add_partition_disarm_failed_counter branch January 4, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a fail_disarm counter in the attributes of the control panel
1 participant