Skip to content

Commit

Permalink
Merge pull request #87 from xadrianzetx/support-py-312
Browse files Browse the repository at this point in the history
Explicitly support Python 3.12 + reformat codebase with `black 24.x`
  • Loading branch information
xadrianzetx authored May 12, 2024
2 parents fbccf10 + a2417d9 commit 7b482f8
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 21 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- '3.9'
- '3.10'
- '3.11'
- '3.12'

steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 2 additions & 4 deletions optuna_distributed/managers/distributed.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
DistributableWithContext = Callable[["_TaskContext"], None]


class WorkerInterrupted(Exception):
...
class WorkerInterrupted(Exception): ...


class _TaskState(IntEnum):
Expand Down Expand Up @@ -166,8 +165,7 @@ def get_message(self) -> Generator[Message, None, None]:
# e.g. in `after_message`.
yield HeartbeatMessage()

def after_message(self, event_loop: "EventLoop") -> None:
...
def after_message(self, event_loop: "EventLoop") -> None: ...

def get_connection(self, trial_id: int) -> IPCPrimitive:
return Queue(self._private_channels[trial_id])
Expand Down
3 changes: 1 addition & 2 deletions optuna_distributed/messages/heartbeat.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ class HeartbeatMessage(Message):

closing = False

def process(self, study: Study, manager: "OptimizationManager") -> None:
...
def process(self, study: Study, manager: "OptimizationManager") -> None: ...
3 changes: 1 addition & 2 deletions optuna_distributed/messages/response.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,4 @@ def __init__(self, trial_id: int, data: T) -> None:
self.trial_id = trial_id
self.data = data

def process(self, study: Study, manager: "OptimizationManager") -> None:
...
def process(self, study: Study, manager: "OptimizationManager") -> None: ...
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ classifiers = [
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3 :: Only",
"Topic :: Scientific/Engineering",
"Topic :: Scientific/Engineering :: Mathematics",
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[flake8]
ignore = D203
ignore = D203, E701, E704
exclude =
.git,
__pycache__,
Expand Down
15 changes: 5 additions & 10 deletions tests/test_messages.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,32 +43,27 @@ def put(self, message: Message) -> None:
assert isinstance(message, ResponseMessage)
self._manager.message_response = message.data

def close(self) -> None:
...
def close(self) -> None: ...


class MockOptimizationManager(OptimizationManager):
def __init__(self) -> None:
self.trial_exit_called = False
self.message_response = None

def create_futures(self, study: "Study", objective: ObjectiveFuncType) -> None:
...
def create_futures(self, study: "Study", objective: ObjectiveFuncType) -> None: ...

def before_message(self, event_loop: "EventLoop") -> None:
...
def before_message(self, event_loop: "EventLoop") -> None: ...

def get_message(self) -> Generator["Message", None, None]:
yield HeartbeatMessage()

def after_message(self, event_loop: "EventLoop") -> None:
...
def after_message(self, event_loop: "EventLoop") -> None: ...

def get_connection(self, trial_id: int) -> "IPCPrimitive":
return MockConnection(self)

def stop_optimization(self, patience: float) -> None:
...
def stop_optimization(self, patience: float) -> None: ...

def should_end_optimization(self) -> bool:
return True
Expand Down
3 changes: 1 addition & 2 deletions tests/test_trial.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ def get(self) -> "Message":
def put(self, message: "Message") -> None:
self.captured.append(message)

def close(self) -> None:
...
def close(self) -> None: ...

def enqueue_response(self, response: ResponseMessage) -> None:
self.responses.append(response)
Expand Down

0 comments on commit 7b482f8

Please sign in to comment.