Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonrpc): switch to spec 0.5.1 #505

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

xJonathanLEI
Copy link
Owner

Here we go 0.5.x.

@glihm
Copy link
Contributor

glihm commented Nov 24, 2023

Could be great to have your feedback on #483 to be compliant with the JSON RPC spec, now that the starknet spec is using the data field on the error at least once in CONTRACT_ERROR.

Also this will be very helpful to have the data field returned by providers, important for debugging in some situations.

@xJonathanLEI xJonathanLEI merged commit 64ebc36 into master Nov 27, 2023
24 checks passed
@xJonathanLEI xJonathanLEI deleted the dev/jsonrpc_0_5_0 branch November 27, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants