Make the error link only apply to the first label #43
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was affecting all labels in the collection and causing invalid markup. Now the first label is associated with the first input and when errors are present on the attribute both id and for are changed accordingly
peteryates
added a commit
that referenced
this pull request
Oct 1, 2019
Similar to #43, this fixes a bug with fieldsets with errors where all labels were associated with the first input.
peteryates
added a commit
that referenced
this pull request
Jan 9, 2020
Make the error link only apply to the first label. Previously it was affecting all labels in the collection and causing invalid markup. Now the first label is associated with the first input and when errors are present on the attribute both id and for are changed accordingly
peteryates
added a commit
that referenced
this pull request
Jan 9, 2020
Similar to #43, this fixes a bug with fieldsets with errors where all labels were associated with the first input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was affecting all labels in the collection and causing
invalid markup. Now the first label is associated with the first
input and when errors are present on the attribute both id and for are
changed accordingly